chore(extension-logging): fix typos and clean up descriptions#4575
Merged
Conversation
agnes512
approved these changes
Feb 6, 2020
nabdelgadir
approved these changes
Feb 6, 2020
raymondfeng
force-pushed
the
fix-logging-typo
branch
2 times, most recently
from
February 6, 2020 17:15
35c5607 to
7f697d6
Compare
jannyHou
approved these changes
Feb 6, 2020
dhmlau
reviewed
Feb 6, 2020
dhmlau
approved these changes
Feb 6, 2020
dhmlau
left a comment
dhmlau
left a comment
Member
There was a problem hiding this comment.
I think the typo in the folder for fluent.acceptance.ts is not fixed yet. Other than that, LGTM.
raymondfeng
force-pushed
the
fix-logging-typo
branch
from
February 6, 2020 18:02
7f697d6 to
dfe43e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4117 (comment)
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈